Adar Dembo has posted comments on this change. Change subject: KUDU-1165: Implement partition pruning for C++ client and server ......................................................................
Patch Set 20: (whoops, forgot to include the large comment. Here I go again) Wow, very complex looking algorithm. I didn't see any errors, though to be honest given the complexity I don't expect that I _could_ see any if they existed. Most of my comments were questions about how stuff works. Since this is rather complex, I'm wondering if it's possible to conditionally disable the pruning with a gflag? Then if someone runs into a pruning in production they can disable it (it's just an optimization after all). Not sure how well that'll work here, though, since this is client-side (so the toggle would need to be exposed in the client API, and then somehow in Impala), and scans now must go through the PartitionPruner class one way or the other. Maybe it'll be more applicable for the server-side part. -- To view, visit http://gerrit.cloudera.org:8080/2413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f4fc14b44af63a17b34cd9c2a9134127b1afe4d Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
