Adar Dembo has posted comments on this change. Change subject: KUDU-1165: Implement partition pruning for C++ client and server ......................................................................
Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/2413/20/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: Line 165: // DISTRIBUTE BY RANGE (c) > I think I was unclear in our discussion. Having range columns, regardless I see what you're saying, and I don't have a clear-cut answer. I guess we just need to make sure that the spec (which is probably required reading for this code) explains the effect of range columns sans split keys in detail. Line 173: // | a = 0 | [(bucket=0, bucket=2, c=0), (bucket=0, bucket=2, c=1)) | > The opening bracket matches up with a closing paren to indicate a closed, o Oh okay, makes sense. -- To view, visit http://gerrit.cloudera.org:8080/2413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f4fc14b44af63a17b34cd9c2a9134127b1afe4d Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
