Adar Dembo has posted comments on this change. Change subject: KUDU-839. Add Status class to Java client for use in RowError ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2640/1/java/kudu-client/src/main/java/org/kududb/Status.java File java/kudu-client/src/main/java/org/kududb/Status.java: Line 50: public static Status fromPB(WireProtocol.AppStatusPB pb) { Hmm, does public here mean 'public API' or 'public to the rest of the client, but hidden from users'? It should definitely be the latter; wondering if you had to make it public due to the package you placed it in. Line 56: * @deprecated Call {@link #toString()} instead. Why add @deprecated functions to a new class? Oh I see; this and getCodeName() are here to satisfy some of the old methods in RowError. Could you put this class in org.kududb.client and then make these package private? Line 147: public static Status OK() { Nit: not a fan of the intermingling of static factory methods and boolean checks. Could you reorganize them so one set of methods comes first, then the other? -- To view, visit http://gerrit.cloudera.org:8080/2640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e3c949cf441b7dd798c5001aeed747457a8807 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
