Mike Percy has posted comments on this change. Change subject: KUDU-839. Add Status class to Java client for use in RowError ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/2640/1/java/kudu-client/src/main/java/org/kududb/Status.java File java/kudu-client/src/main/java/org/kududb/Status.java: Line 17: package org.kududb; > Should this be in client instead? Would also help hiding the PB in public m Done Line 22: */ > Add the interface audience and stability. Done Line 24: private WireProtocol.AppStatusPB appStatusPB; > final Done Line 50: public static Status fromPB(WireProtocol.AppStatusPB pb) { > Hmm, does public here mean 'public API' or 'public to the rest of the clien Yeah, moved to client Line 56: * @deprecated Call {@link #toString()} instead. > Why add @deprecated functions to a new class? Done Line 147: public static Status OK() { > Nit: not a fan of the intermingling of static factory methods and boolean c Done http://gerrit.cloudera.org:8080/#/c/2640/1/java/kudu-client/src/test/java/org/kududb/util/TestStatus.java File java/kudu-client/src/test/java/org/kududb/util/TestStatus.java: Line 17: package org.kududb.util; > Why util? oops, intellij misclick. -- To view, visit http://gerrit.cloudera.org:8080/2640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e3c949cf441b7dd798c5001aeed747457a8807 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
