Mike Percy has posted comments on this change. Change subject: KUDU-839. Add Status class to Java client for use in RowError ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2640/2/java/kudu-client/src/main/java/org/kududb/client/Status.java File java/kudu-client/src/main/java/org/kududb/client/Status.java: Line 59: * Package-private because we Shade Protobuf and this is not usable outside this package. > Nit: shade ok Line 61: @InterfaceAudience.Private > Does it need interface annotations if it's package private? How would an ap It's one of those things that you and I typically disagree about -- adding a functional thing that isn't really required as "documentation". But I'll remove this from here and leave the comment. Line 316: * This method will be removed in the future. > Less of a big deal now that these methods are package-private. In fact, why as above -- To view, visit http://gerrit.cloudera.org:8080/2640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e3c949cf441b7dd798c5001aeed747457a8807 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
