Mike Percy has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics ......................................................................
Patch Set 4: (7 comments) I'm still reading through the linked paper and the design but I thought I'd post nits mostly related to readability / rendering of the doc http://gerrit.cloudera.org:8080/#/c/2642/4/docs/design-docs/rpc-retry-and-failover.md File docs/design-docs/rpc-retry-and-failover.md: Line 20: RPCss are not idempotent i.e. if handled twice they will lead to incorrect state nit: s/RPCss/RPCs/ Line 22: is guaranteed to execute it **Exactly Once**. nit: no need to capitalize exactly once Line 28: 1. Doesn't need Exactly Once - Operations that don't mutate server state. nit: instead of capitalizing Exactly Once here and below, we can have it read like prose by using a phrase such as exactly-once guarantees or exactly-once semantics. Line 34: 3. Needs Exactly Once but has an alternative - Operations like in 2 but that already Missing: Needs exactly once but an alternative mechanism is required (e.g. CAS) because exactly once semantics as designed here are not sufficient for the use case (perhaps some multi-master ops are like this) Line 37: 4. Require Exactly Once for correctness - Operations that don't currently have E.O. implemented nit: s/Require/Requires/ to maintain singular tense in this list Line 83: - No Op - A passthrough, no-op component that just delegates to what handling we already nit: This doesn't render properly in HTML. Push to a personal GitHub branch and check out how this renders. Here is version 2 of this CR: https://github.com/mpercy/kudu/blob/replay-cache-1/docs/design-docs/rpc-retry-and-failover.md Line 279: [1](web.stanford.edu/~ouster/cgi-bin/papers/rifl.pdf "Implementing Linearizability at Large Scale and Low Latency") nit: This doesn't render well as HTML. How about: 1. [Implementing Linearizability at Large Scale and Low Latency](http://web.stanford.edu/~ouster/cgi-bin/papers/rifl.pdf) -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2aa40486153b39724e1c9bd09c626b829274c6 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
