Mike Percy has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/2642/4/docs/design-docs/rpc-retry-and-failover.md File docs/design-docs/rpc-retry-and-failover.md: Line 34: 3. Needs Exactly Once but has an alternative - Operations like in 2 but that already > can you come up with a case where this would happen? See below comments regarding master ops that change clients and repeat Line 119: each client request is : recorded by the consensus log almost as is so it wouldn't be problematic to additionally store : the client id and request seq no. so when a write is "consensus committed" all future handlers : of that write (future leaders) will automatically be able to identify the client and request > My idea was to make this a general design doc supposed to drive discussion I disagree. That level of detail is required to verify correctness of the design. I honestly have no idea how we are planning to store responses. See my overall doc-level comment on this revision for all the stuff I think is missing from this doc. Line 178: Retry handling on the client side and retry rendez-vous logic will be implemented at the > You're essentially describing the problem that distributed transactions sol No, I'm talking about identifying specific rows for insert and being able to replay those specific row inserts in a way that would identify them as having been successfully inserted (or not). I'm not talking about atomic transactions here. Line 235: These operations are called by the master and already handle at least once. They might benefit > The argument of the previous reviewers on this one is that these are alread My point is that they do not benefit from this at all, and should be called out as a separate class of operation -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2aa40486153b39724e1c9bd09c626b829274c6 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
