David Ribeiro Alves has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2642/4/docs/design-docs/rpc-retry-and-failover.md File docs/design-docs/rpc-retry-and-failover.md: Line 119: each client request is : recorded by the consensus log almost as is so it wouldn't be problematic to additionally store : the client id and request seq no. so when a write is "consensus committed" all future handlers : of that write (future leaders) will automatically be able to identify the client and request > I disagree. That level of detail is required to verify correctness of the d Did you see the last rev? I've updated milestone 1 to make even clearer that we _don't_ store (in the persistent sense) the responses. In fact we don't store anything new in the wal besides the client id and the seq nos that go into the already existing WriteRequests. Also left a general comment replying (or rather asking for further info) on your general questions. Line 178: Retry handling on the client side and retry rendez-vous logic will be implemented at the > No, I'm talking about identifying specific rows for insert and being able t The client is Line 235: These operations are called by the master and already handle at least once. They might benefit > My point is that they do not benefit from this at all, and should be called Previous comment from Todd: I think these RPCs are more like 'cat 3' by your terminology -- they have feasible alternatives already (eg a duplicated CreateTablet or DeleteTablet is fine). -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2aa40486153b39724e1c9bd09c626b829274c6 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
