Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Add a way to restart processes ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2828/1/java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java: Line 375: Thread.sleep(1000); > It's odd for this behavior to be baked into methods with generic "restart" MiniKuduCluster also offers public killTabletServerOnPort and restartDeadTabletServerOnPort methods, BaseKuduTest is a specialization where we (at this point at least) only care restarting with a pause. http://gerrit.cloudera.org:8080/#/c/2828/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 56: private final Map<Integer, String[]> commandLines = new ConcurrentHashMap<>(); > A wrapper doesn't have to get in the way if it subclasses Process, override Ok so that'd solve problem #1 and #2 (not bad), but we'd still need the third map because of #3. -- To view, visit http://gerrit.cloudera.org:8080/2828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I065917cd219e1dd8fa93fed9ca36d58a3372935d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
