Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Add a way to restart processes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2828/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 56: private final Map<Integer, String[]> commandLines = new ConcurrentHashMap<>(); > > A TS that shows up on a different port but with the same UUID is currentl Oh I see you're concerned about adding new servers. Mmm, then keeping the historical list wouldn't work that well because we wouldn't be able to restart old processes on newly occupied port. If I add to implement the adding of tservers, I would start keeping track of the latest port that's assigned and use that as a start point for the next request to TestUtils.findFreePorts(). Also, using List<KuduProcess> isn't as nice as a map since we do everything by port number at the mo, so we'd need to search the list for the process we're looking for when we want to restart a dead process. I guess we could use the UUID instead. I still wouldn't want new servers to use ports from dead ones. -- To view, visit http://gerrit.cloudera.org:8080/2828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I065917cd219e1dd8fa93fed9ca36d58a3372935d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
