Adar Dembo has posted comments on this change. Change subject: [java client] Add a way to restart processes ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2828/2/java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java: Line 58: // Currently not seeding it since we want a random behavior when running tests that restart tablet : // servers. > If we were seeding the random then we'd get events in the same order? I don't understand what you're trying to say, but I'll try to make my point more clearly: even though you're not passing any arguments into the Random constructor, the PRNG inside it is still being seeded. From the Javadocs "Creates a new random number generator. This constructor sets the seed of the random number generator to a value very likely to be distinct from any other invocation of this constructor." My guess is it uses some combination of the current time and maybe a thread ID as the seed. My point is: given this behavior, the comment here doesn't make sense, because we _are_ seeding the PRNG, we're just letting the JVM choose some arbitrary seed. -- To view, visit http://gerrit.cloudera.org:8080/2828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I065917cd219e1dd8fa93fed9ca36d58a3372935d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
