Todd Lipcon has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/2970/10//COMMIT_MSG Commit Message: Line 10: th two? Line 10: ) W and? Line 16: This is a percursor to other changes that will pull this logic out of precursor http://gerrit.cloudera.org:8080/#/c/2970/10/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 441: Prefer early this is an old comment, but I don't really understand it. What's an "early failure"? Line 518: return true; shouldn't this and the 'return true' down below on L523 also just be 'break' so that we end up retrying? It seems like here we aren't actually retrying ever... if that's the case, are we lacking a lot of test coverage here? -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
