David Ribeiro Alves has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/2970/10//COMMIT_MSG Commit Message: Line 10: th > two? Done Line 10: ) W > and? Done Line 16: This is a percursor to other changes that will pull this logic out of > precursor Done http://gerrit.cloudera.org:8080/#/c/2970/10/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 441: Prefer early > this is an old comment, but I don't really understand it. What's an "early Yeah, confused me too. I think it refers to "early" failures like lookup or proxy initialization. Line 518: return true; > shouldn't this and the 'return true' down below on L523 also just be 'break yeah pulled something from the following patch and botched it. Done -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
