David Ribeiro Alves has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/2970/7/src/kudu/rpc/replicated_rpc.h File src/kudu/rpc/replicated_rpc.h: Line 22: // Result status of a replicated Rpc. > I still think this needs to be addressed in some way. At the very least, yo All right. You've convinced me. I removed "replicated" and replaced it with "Retriable" to make it more generic. Also left a TODO to consider merging this with ScanRpcStatus. Finally changed the name of the enums to refer to "replica" less (though it sometimes still needs it) I won't do a scan/write refactor though, too much of a scope creep, plus the scan code is way too specific. In any case you've inspired me to make the refactor in such a way that it is not meant only for "replicated" rpcs. Line 23: struct ReplicatedRpcStatus { > I won't lie; I was hoping you'd take the refactoring further and find a goo see my comment above. -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
