----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review123110 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (lines 1013 - 1275) <https://reviews.apache.org/r/44612/#comment185262> The `toString` needs to be checked. Can you add new test cases in `lens-examples/src/main/resources` and `lens-examples/src/test/resources/yaml`? lens-api/src/main/resources/cube-0.1.xsd (line 1291) <https://reviews.apache.org/r/44612/#comment185261> fact has `cube_name` field for this purpose. Can we name this to `cube_name` too? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 803) <https://reviews.apache.org/r/44612/#comment185263> Can the argument be `CubeSegmentation` instead of `AbstractCubeTable`? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 40) <https://reviews.apache.org/r/44612/#comment185267> Do we need a dummy column? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 85) <https://reviews.apache.org/r/44612/#comment185268> Shall we take care of the case when comma list of cubes is a string larger than 4000? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (lines 136 - 158) <https://reviews.apache.org/r/44612/#comment185271> Should these be part of `AbstractCubeTable`? Since it seems now most of the entities have start-end times. - Rajat Khandelwal On March 10, 2016, 2:03 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44612/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 2:03 p.m.) > > > Review request for lens. > > > Bugs: LENS-975 > https://issues.apache.org/jira/browse/LENS-975 > > > Repository: lens > > > Description > ------- > > Added cube segmantation specification and metastore CRUD operations. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 0f4dbea > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 01098c4 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 643bcfe > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > ec1c837 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > ed78d74 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > deb5368 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 65387c6 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6fd19a0 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a541e9b > > Diff: https://reviews.apache.org/r/44612/diff/ > > > Testing > ------- > > Added unit test for cubesegmentation metastore operation. mvn clean install > runs fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s] > [INFO] Lens .............................................. SUCCESS [3.135s] > [INFO] Lens API .......................................... SUCCESS [27.415s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.108s] > [INFO] Lens Cube ......................................... SUCCESS > [11:11.002s] > [INFO] Lens DB storage ................................... SUCCESS [19.140s] > [INFO] Lens Query Library ................................ SUCCESS [15.036s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s] > [INFO] Lens Server ....................................... SUCCESS > [16:03.100s] > [INFO] Lens client ....................................... SUCCESS [36.084s] > [INFO] Lens CLI .......................................... SUCCESS [53.148s] > [INFO] Lens Examples ..................................... SUCCESS [12.655s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s] > [INFO] Lens Distribution ................................. SUCCESS [9.223s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s] > [INFO] Lens Regression ................................... SUCCESS [13.778s] > [INFO] Lens UI ........................................... SUCCESS [28.603s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:20.155s > [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016 > [INFO] Final Memory: 210M/2450M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
