> On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd, lines 1013-1275 > > <https://reviews.apache.org/r/44612/diff/1/?file=1294162#file1294162line1013> > > > > The `toString` needs to be checked. Can you add new test cases in > > `lens-examples/src/main/resources` and > > `lens-examples/src/test/resources/yaml`?
added. > On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 803 > > <https://reviews.apache.org/r/44612/diff/1/?file=1294165#file1294165line803> > > > > Can the argument be `CubeSegmentation` instead of `AbstractCubeTable`? Yes it can be. Cube fact is using AbstractCubeTable. Missed in the current patch, will take care in the next patch. > On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, > > line 40 > > <https://reviews.apache.org/r/44612/diff/1/?file=1294166#file1294166line40> > > > > Do we need a dummy column? Yes we need this for the super constructor, AbstractCubeTable does the same. > On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, > > lines 136-158 > > <https://reviews.apache.org/r/44612/diff/1/?file=1294166#file1294166line136> > > > > Should these be part of `AbstractCubeTable`? Since it seems now most of > > the entities have start-end times. Moving these methods to AbstractCubeTable need implementation in all its clildren i.e storage, dimension, derived_cube which might not be relevant to them. Should we add one more abstraction in between AbstractCubeTable and CubeFactTable/CubeSegmentation? In this case the property names are different. - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review123110 ----------------------------------------------------------- On March 17, 2016, 9:04 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44612/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 9:04 a.m.) > > > Review request for lens. > > > Bugs: LENS-975 > https://issues.apache.org/jira/browse/LENS-975 > > > Repository: lens > > > Description > ------- > > Added cube segmantation specification and metastore CRUD operations. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 0f4dbea > > lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java > PRE-CREATION > > lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java > PRE-CREATION > > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java > PRE-CREATION > lens-cli/src/test/resources/seg1.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > d0f2b57 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 01098c4 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 643bcfe > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > ec1c837 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > ed78d74 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > deb5368 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 0935509 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 65387c6 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 0c2301b > lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION > lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 1b7d0f9 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6fd19a0 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a541e9b > > Diff: https://reviews.apache.org/r/44612/diff/ > > > Testing > ------- > > Added unit test for cubesegmentation metastore operation. mvn clean install > runs fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s] > [INFO] Lens .............................................. SUCCESS [4.354s] > [INFO] Lens API .......................................... SUCCESS [29.857s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.179s] > [INFO] Lens Cube ......................................... SUCCESS > [11:10.012s] > [INFO] Lens DB storage ................................... SUCCESS [20.014s] > [INFO] Lens Query Library ................................ SUCCESS [15.666s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:48.066s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.218s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.893s] > [INFO] Lens Server ....................................... SUCCESS > [16:37.655s] > [INFO] Lens client ....................................... SUCCESS [47.034s] > [INFO] Lens CLI .......................................... SUCCESS [57.465s] > [INFO] Lens Examples ..................................... SUCCESS [15.509s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.209s] > [INFO] Lens Distribution ................................. SUCCESS [22.002s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:36.655s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.019s] > [INFO] Lens Regression ................................... SUCCESS [14.401s] > [INFO] Lens UI ........................................... SUCCESS [29.585s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 37:49.065s > [INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016 > [INFO] Final Memory: 173M/2915M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
