----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review124358 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (line 1026) <https://reviews.apache.org/r/44612/#comment186858> Should say different in underlying cube? instead of cubes? lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java (line 26) <https://reviews.apache.org/r/44612/#comment186860> Irrational looks more a negative word. Do you want to call it Base or Generic ? lens-cli/src/test/resources/seg1.xml (line 31) <https://reviews.apache.org/r/44612/#comment186863> Property should be lens.metastore.cube.column.mapping lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 33) <https://reviews.apache.org/r/44612/#comment186864> Properties of the cubeSegments are not stored here? lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java (line 64) <https://reviews.apache.org/r/44612/#comment186865> Not documented in xsd? lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java (line 169) <https://reviews.apache.org/r/44612/#comment186868> Empty method? Can you add example creation? lens-examples/src/main/resources/cube-segmentation1.xml (line 30) <https://reviews.apache.org/r/44612/#comment186870> Property should lens.metastore.cube.column.mapping. lens-examples/src/main/resources/cube-segmentation1.xml (line 35) <https://reviews.apache.org/r/44612/#comment186872> Can you give separate for propeties for each segment ? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 675) <https://reviews.apache.org/r/44612/#comment186877> Can we rename method - cubeSegmentationFromXCubeSegmentation ? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 685) <https://reviews.apache.org/r/44612/#comment186874> Instead with should check - ! (prop.toLowerCase().startsWith(MetastoreUtil.SEGMENTATION_PREFIX) lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 711) <https://reviews.apache.org/r/44612/#comment186876> Can we name method xcubeSegmenationFromCubeSegmentation? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 719) <https://reviews.apache.org/r/44612/#comment186875> Skip properties check should be in this method. - Amareshwari Sriramadasu On March 18, 2016, 11:12 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44612/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 11:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-975 > https://issues.apache.org/jira/browse/LENS-975 > > > Repository: lens > > > Description > ------- > > Added cube segmantation specification and metastore CRUD operations. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 0f4dbea > > lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java > PRE-CREATION > > lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java > PRE-CREATION > > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java > PRE-CREATION > lens-cli/src/test/resources/seg1.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > d0f2b57 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 01098c4 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 643bcfe > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > ec1c837 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > ed78d74 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > deb5368 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 0935509 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 65387c6 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 0c2301b > lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION > lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 1b7d0f9 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6fd19a0 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a541e9b > > Diff: https://reviews.apache.org/r/44612/diff/ > > > Testing > ------- > > Added unit test for cubesegmentation metastore operation. mvn clean install > runs fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.210s] > [INFO] Lens .............................................. SUCCESS [3.229s] > [INFO] Lens API .......................................... SUCCESS [28.902s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.780s] > [INFO] Lens Cube ......................................... SUCCESS > [11:18.929s] > [INFO] Lens DB storage ................................... SUCCESS [19.804s] > [INFO] Lens Query Library ................................ SUCCESS [15.394s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.339s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.632s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.508s] > [INFO] Lens Server ....................................... SUCCESS > [17:04.269s] > [INFO] Lens client ....................................... SUCCESS [39.871s] > [INFO] Lens CLI .......................................... SUCCESS [57.974s] > [INFO] Lens Examples ..................................... SUCCESS [12.472s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.738s] > [INFO] Lens Distribution ................................. SUCCESS [11.260s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:27.726s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.879s] > [INFO] Lens Regression ................................... SUCCESS [16.056s] > [INFO] Lens UI ........................................... SUCCESS [28.700s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:00.676s > [INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016 > [INFO] Final Memory: 195M/1539M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
