----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45207/#review125184 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java (line 24) <https://reviews.apache.org/r/45207/#comment187969> +1 on exponential backoff using fibonacci. lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java (line 29) <https://reviews.apache.org/r/45207/#comment187979> We may have to synchronize this one too to make sure updateFailure and canTry are in sync lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java (lines 40 - 42) <https://reviews.apache.org/r/45207/#comment187980> If user increases the default max delay or decreases the exponential wait time do we need more entries in Fibonacci or compute it on the fly. lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 377) <https://reviews.apache.org/r/45207/#comment187973> should we make the arguments statusUpdateRetryMaxDelay and statusUpdateExponentialWaitFactor as class memebers instead in QueryContext and ExponentialBackOffRetryHandler ? - Puneet Gupta On March 23, 2016, 10:28 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45207/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 10:28 a.m.) > > > Review request for lens. > > > Bugs: LENS-893 > https://issues.apache.org/jira/browse/LENS-893 > > > Repository: lens > > > Description > ------- > > - Adds next update to happen with increasing wait times upon transient > failures. Adds a max delay to cap the increasing time as well. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 52a7ccc > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ee8a3b > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > c3b6d26 > > lens-server-api/src/test/java/org/apache/lens/server/api/common/TestExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 7f39da1 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 90c25e4 > lens-server/src/main/resources/lensserver-default.xml 6bb66d9 > lens-server/src/test/resources/lens-site.xml b5b3220 > > Diff: https://reviews.apache.org/r/45207/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Amareshwari Sriramadasu > >
