> On March 28, 2016, 1:39 p.m., Puneet Gupta wrote: > > UpdateStatus() is called from getUpdatedQueryContext() also. Do we need to > > fail fast in some specific cases without retrying? > > I am not sure. Most callers of getUpdatedQueryContext look fine with > > retries. Please check once from your side.
With exponential backoff on next update, any update status call will return immediately without trying to update status until nextUpdateTime. There are no new retries introduced on the existing api. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45207/#review125631 ----------------------------------------------------------- On March 28, 2016, 12:40 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45207/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 12:40 p.m.) > > > Review request for lens. > > > Bugs: LENS-893 > https://issues.apache.org/jira/browse/LENS-893 > > > Repository: lens > > > Description > ------- > > - Adds next update to happen with increasing wait times upon transient > failures. Adds a max delay to cap the increasing time as well. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f8a936a > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ee8a3b > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > c3b6d26 > > lens-server-api/src/test/java/org/apache/lens/server/api/common/TestExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 7f39da1 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 5af45ed > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 581530f > lens-server/src/main/resources/lensserver-default.xml 6bb66d9 > lens-server/src/test/resources/lens-site.xml b5b3220 > src/site/apt/admin/config.apt 6df9796 > src/site/apt/user/client-config.apt 714db18 > > Diff: https://reviews.apache.org/r/45207/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Amareshwari Sriramadasu > >
