----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45207/#review125817 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java (line 44) <https://reviews.apache.org/r/45207/#comment188689> can we add an interface too, so that the clients of this class can not depend on the implementation. lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java (line 27) <https://reviews.apache.org/r/45207/#comment188690> Should the name be more revealing of the fact that it's status-update failure context, not a query failure context? lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 36) <https://reviews.apache.org/r/45207/#comment188692> Let's depend on an interface here. It's possible that the implementation needs to be picked based on the selected driver, or any other query context parameters. lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java (line 62) <https://reviews.apache.org/r/45207/#comment188691> corner case: `e=null`. - Rajat Khandelwal On March 28, 2016, 6:10 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45207/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 6:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-893 > https://issues.apache.org/jira/browse/LENS-893 > > > Repository: lens > > > Description > ------- > > - Adds next update to happen with increasing wait times upon transient > failures. Adds a max delay to cap the increasing time as well. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f8a936a > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ee8a3b > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > c3b6d26 > > lens-server-api/src/test/java/org/apache/lens/server/api/common/TestExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 7f39da1 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 5af45ed > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 581530f > lens-server/src/main/resources/lensserver-default.xml 6bb66d9 > lens-server/src/test/resources/lens-site.xml b5b3220 > src/site/apt/admin/config.apt 6df9796 > src/site/apt/user/client-config.apt 714db18 > > Diff: https://reviews.apache.org/r/45207/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Amareshwari Sriramadasu > >
