----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review125240 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java (line 25) <https://reviews.apache.org/r/44612/#comment188032> Can you implement Named? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 63) <https://reviews.apache.org/r/44612/#comment188033> What is this update for? I see addCubeSegmentProperties is already adding properties lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 90) <https://reviews.apache.org/r/44612/#comment188034> You can use MetastoreUtil.addNameStrings, once CubeSegment implements Named lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 103) <https://reviews.apache.org/r/44612/#comment188035> Similarly call MetastoreUtil.getNamedStringValue - Amareshwari Sriramadasu On March 23, 2016, 3:32 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44612/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 3:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-975 > https://issues.apache.org/jira/browse/LENS-975 > > > Repository: lens > > > Description > ------- > > Added cube segmantation specification and metastore CRUD operations. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 0f4dbea > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java > PRE-CREATION > > lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java > PRE-CREATION > > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java > PRE-CREATION > lens-cli/src/test/resources/seg1.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > d0f2b57 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 01098c4 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 643bcfe > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > ec1c837 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > ed78d74 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > deb5368 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 0935509 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 65387c6 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 0c2301b > lens-examples/src/main/resources/seg1.xml PRE-CREATION > lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 1b7d0f9 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6fd19a0 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a541e9b > > Diff: https://reviews.apache.org/r/44612/diff/ > > > Testing > ------- > > Added unit test for cubesegmentation metastore operation. mvn clean install > runs fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.832s] > [INFO] Lens .............................................. SUCCESS [2.986s] > [INFO] Lens API .......................................... SUCCESS [29.786s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.855s] > [INFO] Lens Cube ......................................... SUCCESS > [11:11.234s] > [INFO] Lens DB storage ................................... SUCCESS [19.346s] > [INFO] Lens Query Library ................................ SUCCESS [14.612s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:54.155s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.385s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.973s] > [INFO] Lens Server ....................................... SUCCESS > [16:20.530s] > [INFO] Lens client ....................................... SUCCESS [37.472s] > [INFO] Lens CLI .......................................... SUCCESS [53.129s] > [INFO] Lens Examples ..................................... SUCCESS [12.618s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.706s] > [INFO] Lens Distribution ................................. SUCCESS [9.672s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.894s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.837s] > [INFO] Lens Regression ................................... SUCCESS [14.615s] > [INFO] Lens UI ........................................... SUCCESS [29.106s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:51.827s > [INFO] Finished at: Wed Mar 23 15:31:55 UTC 2016 > [INFO] Final Memory: 194M/1485M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
