> On March 30, 2016, 9:57 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java, > > lines 30-40 > > <https://reviews.apache.org/r/45207/diff/6/?file=1318721#file1318721line30> > > > > It's fine for now, but I don't like the fact that every user of a > > retry-handler has to write such code. > > > > Maybe when we add retries for launching queries, we can use the command > > pattern. > > > > command = status update command, launch query command etc > > > > command.run() runs the command > > > > there will be a commandwithretry which wraps the command with such > > retry code and using an object of backoffretryhandler. > > > > then commandwithretry can be plugged in in place of command.
Yes. I agree. I also thought there should be one more wrapper on top of this. But havent done in this, let us do it when we have more than one caller. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45207/#review126074 ----------------------------------------------------------- On March 30, 2016, 7:57 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45207/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 7:57 a.m.) > > > Review request for lens. > > > Bugs: LENS-893 > https://issues.apache.org/jira/browse/LENS-893 > > > Repository: lens > > > Description > ------- > > - Adds next update to happen with increasing wait times upon transient > failures. Adds a max delay to cap the increasing time as well. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f8a936a > > lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ee8a3b > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > c3b6d26 > > lens-server-api/src/test/java/org/apache/lens/server/api/common/TestExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 7f39da1 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 5af45ed > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 47efb1c > lens-server/src/main/resources/lensserver-default.xml 6bb66d9 > lens-server/src/test/resources/lens-site.xml b5b3220 > src/site/apt/admin/config.apt 6df9796 > > Diff: https://reviews.apache.org/r/45207/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.855s] > [INFO] Lens .............................................. SUCCESS [3.659s] > [INFO] Lens API .......................................... SUCCESS [28.148s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.164s] > [INFO] Lens Cube ......................................... SUCCESS > [11:19.591s] > [INFO] Lens DB storage ................................... SUCCESS [19.465s] > [INFO] Lens Query Library ................................ SUCCESS [16.949s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.032s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.927s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.006s] > [INFO] Lens Server ....................................... SUCCESS > [16:04.100s] > [INFO] Lens client ....................................... SUCCESS [35.152s] > [INFO] Lens CLI .......................................... SUCCESS [3:04.126s] > [INFO] Lens Examples ..................................... SUCCESS [12.296s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s] > [INFO] Lens Distribution ................................. SUCCESS [9.980s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.873s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.701s] > [INFO] Lens Regression ................................... SUCCESS [13.572s] > [INFO] Lens UI ........................................... SUCCESS [28.777s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:44.028s > [INFO] Finished at: Wed Mar 30 06:02:07 UTC 2016 > [INFO] Final Memory: 171M/2823M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
