----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review141266 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java (line 49) <https://reviews.apache.org/r/49371/#comment206706> shoudl we use driverLaunchedQueries.size() here. lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java (line 97) <https://reviews.apache.org/r/49371/#comment206707> Suggestion : should we change the name to getIsLauchingCount() lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java (line 76) <https://reviews.apache.org/r/49371/#comment206708> Should we have a default value of 10/20 ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2535) <https://reviews.apache.org/r/49371/#comment206709> should we log the query id or will it come from MDC ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 659) <https://reviews.apache.org/r/49371/#comment206713> Should we remove errorCollection from constructor too ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 752) <https://reviews.apache.org/r/49371/#comment206714> org.apache.lens.server.session.LensSessionImpl#acquire is synchronized . Should we look at reducing the scope of synchronization here or in another JIRA ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (lines 773 - 779) <https://reviews.apache.org/r/49371/#comment206717> Do we need to synchronize the entire run method on context ? I can think of only one reason - cancel and launch happening parallely before this JIRA were synchronized. Not sure if there can be more reasons to do this. If we do syncronize , this code will not be needed. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 801) <https://reviews.apache.org/r/49371/#comment206718> should we do this in finally{} lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1461) <https://reviews.apache.org/r/49371/#comment206720> Do we need to have metrics around laucher pool(number of active thread, queries in launching state) ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1470) <https://reviews.apache.org/r/49371/#comment206719> do we need to make this class level varaible ? - Puneet Gupta On July 6, 2016, 8:47 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49371/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 8:47 a.m.) > > > Review request for lens. > > > Bugs: LENS-1168 > https://issues.apache.org/jira/browse/LENS-1168 > > > Repository: lens > > > Description > ------- > > Changes include : > - Add query launcher pool which would launch queries after applying > constraint checks. > - Add max concurrent launching queries constraint - to limit number parallel > launches at any time. > - Update StatusPoller to skip launching queries > - Update cancelQuery to interrupt launcher. > - Added test to verify parallel launches. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ba0689 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > b2319a9 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > 442cd99 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 38b74ae > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2de098d > lens-server/src/main/resources/lensserver-default.xml 6dc322e > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 0b38517 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 6af4225 > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > c8ebd0c > src/site/apt/admin/config.apt 5b76069 > > Diff: https://reviews.apache.org/r/49371/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
