----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review141638 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 205) <https://reviews.apache.org/r/49371/#comment206986> I feel adding a new state would be better than adding a boolean which is true only for an intermediate phase between two particular states, and false every other time. Having the boolean makes understanding the stata machine difficult for new people. Then state machine would be `NEW->QUEUED->LAUNCHING->LAUNCHED->RUNNING->...` lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1461) <https://reviews.apache.org/r/49371/#comment206984> We'll need to stop the pool in `prepareStopping` - Rajat Khandelwal On July 6, 2016, 2:17 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49371/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 2:17 p.m.) > > > Review request for lens. > > > Bugs: LENS-1168 > https://issues.apache.org/jira/browse/LENS-1168 > > > Repository: lens > > > Description > ------- > > Changes include : > - Add query launcher pool which would launch queries after applying > constraint checks. > - Add max concurrent launching queries constraint - to limit number parallel > launches at any time. > - Update StatusPoller to skip launching queries > - Update cancelQuery to interrupt launcher. > - Added test to verify parallel launches. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ba0689 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > b2319a9 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > 442cd99 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 38b74ae > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2de098d > lens-server/src/main/resources/lensserver-default.xml 6dc322e > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 0b38517 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 6af4225 > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > c8ebd0c > src/site/apt/admin/config.apt 5b76069 > > Diff: https://reviews.apache.org/r/49371/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
