> On July 8, 2016, 10:45 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > lines 787-793 > > <https://reviews.apache.org/r/49371/diff/2/?file=1437569#file1437569line787> > > > > Do we need to synchronize the entire run method on context ? > > I can think of only one reason - cancel and launch happening parallely > > before this JIRA were synchronized. Not sure if there can be more reasons > > to do this. > > > > If we do syncronize , this code will not be needed. > > Amareshwari Sriramadasu wrote: > Did not want to synchronize on the entire method, as other operations > like getStatus or cancelQuery would block threads for this launching thread.
Doing synchronization on the whole launch - same as the earlier flow. cancel and updatestatus will wait if launch takes more time. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review141266 ----------------------------------------------------------- On July 12, 2016, 5:41 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49371/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 5:41 a.m.) > > > Review request for lens. > > > Bugs: LENS-1168 > https://issues.apache.org/jira/browse/LENS-1168 > > > Repository: lens > > > Description > ------- > > Changes include : > - Add query launcher pool which would launch queries after applying > constraint checks. > - Add max concurrent launching queries constraint - to limit number parallel > launches at any time. > - Update StatusPoller to skip launching queries > - Update cancelQuery to interrupt launcher. > - Added test to verify parallel launches. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 7fd2d81 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ba0689 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > d10ad09 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > b2319a9 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > 442cd99 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 38b74ae > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 1e8d540 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2de098d > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > e77c7fa > lens-server/src/main/resources/lensserver-default.xml 6dc322e > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > d5e975a > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 0b38517 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > 0df436a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 6af4225 > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > c8ebd0c > src/site/apt/admin/config.apt 5b76069 > > Diff: https://reviews.apache.org/r/49371/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
