----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review184038 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 429 (patched) <https://reviews.apache.org/r/61881/#comment260040> Are we sure that ClientErrorException is the only execption we are seeing when this issue is hit? If we do not have logs to corroborate this, other run time execptions should be handled too lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 430 (patched) <https://reviews.apache.org/r/61881/#comment260039> out.writeInt(SESSION_MAP.size()) would be wrong in this case . It should be SESSION_MAP.size()-1. How do we handle this ? - Puneet Gupta On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 8:11 a.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > ------- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d14 > > > Diff: https://reviews.apache.org/r/61881/diff/1/ > > > Testing > ------- > > > Thanks, > > Ankit Kailaswar > >
