> On Aug. 29, 2017, 10:19 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > > Lines 430 (patched) > > <https://reviews.apache.org/r/61881/diff/1/?file=1802852#file1802852line430> > > > > out.writeInt(SESSION_MAP.size()) would be wrong in this case . It > > should be SESSION_MAP.size()-1. How do we handle this ?
changed logs to display correct value for number of session persisted. - Ankit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review184038 ----------------------------------------------------------- On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 12:07 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > ------- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d140 > > > Diff: https://reviews.apache.org/r/61881/diff/2/ > > > Testing > ------- > > > Thanks, > > Ankit Kailaswar > >
