> On Aug. 28, 2017, 10:36 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > > Lines 428 (patched) > > <https://reviews.apache.org/r/61881/diff/1/?file=1802852#file1802852line428> > > > > ClientError path should not come in server path. Can we avoid this?
BaseLensService for getSession is throwing ClientErrorException for, 1. invalid session handle 2. if resource for session is release my HiveSessionManager. Ideally we shoud throw ClientErrorException for invalid session only. Only possible reason for "2" is since we are using Hive session manager in lens to retrieve HiveSession object. We can discuss this later to decide for what could be better approach here. - Ankit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review183912 ----------------------------------------------------------- On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 12:07 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > ------- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d140 > > > Diff: https://reviews.apache.org/r/61881/diff/2/ > > > Testing > ------- > > > Thanks, > > Ankit Kailaswar > >
