[
https://issues.apache.org/jira/browse/LENS-1545?focusedWorklogId=275848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275848
]
ASF GitHub Bot logged work on LENS-1545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/19 11:59
Start Date: 12/Jul/19 11:59
Worklog Time Spent: 10m
Work Description: RajashekharChoukimath commented on pull request #34:
[LENS-1545]: Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r302950272
##########
File path:
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
##########
@@ -2054,8 +2056,14 @@ public QueryPrepareHandle prepare(LensSessionHandle
sessionHandle, String query,
acquire(sessionHandle);
prepared = prepareQuery(sessionHandle, query, lensConf,
SubmitOp.PREPARE);
prepared.setQueryName(queryName);
- prepared.getSelectedDriver().prepare(prepared);
+ try {
Review comment:
For the prepared query, I am inserting start_time and timeTaken(this can
deduce the end_time if needed).
Regarding the NumberOfPrepared queries, it is already being emitted
PREPARED_QUERIES_COUNTER. Regarding the query prepare time is already present
in database.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 275848)
Time Spent: 50m (was: 40m)
> Fixed a Bug and made changes for PreparedQuery
> ----------------------------------------------
>
> Key: LENS-1545
> URL: https://issues.apache.org/jira/browse/LENS-1545
> Project: Apache Lens
> Issue Type: Improvement
> Components: api, cube, server
> Reporter: Rajashekhar
> Assignee: Amareshwari Sriramadasu
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Fixed following Issues in Lens for Azure Migrations
> # Bug in Lens-Metastore for single fact granularity --
> https://issues.apache.org/jira/browse/LENS-1544. Explaination: This had a
> special case for handling facts with one-update-period and
> multiple-update-periods. The case which handled one-update-period had a bug
> while generating the name of the hive table whole format is
> update_period-fact_name, the update_period was coming as null.
> # JDBCDriver.java was invoking JDBC Driver while validating the prepared
> query, I don't need this functionality so blocking this via already existing
> config parameter JDBC_VALIDATE_THROUGH_PREPARE.
> 2a) Old Flow:
> {code}
> esitmate()
> --- | --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> ----------------|--> rewrite -- Rewritting take place
> {code}
> 2b) New Flow:
> {code}
> esitmate()
> ---| --> rewrite -- Rewritting take place
> ---| --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
