[
https://issues.apache.org/jira/browse/LENS-1545?focusedWorklogId=276535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276535
]
ASF GitHub Bot logged work on LENS-1545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 07:45
Start Date: 15/Jul/19 07:45
Worklog Time Spent: 10m
Work Description: ankitkailaswar commented on pull request #34:
[LENS-1545]: Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r303304202
##########
File path:
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
##########
@@ -2054,8 +2056,14 @@ public QueryPrepareHandle prepare(LensSessionHandle
sessionHandle, String query,
acquire(sessionHandle);
prepared = prepareQuery(sessionHandle, query, lensConf,
SubmitOp.PREPARE);
prepared.setQueryName(queryName);
- prepared.getSelectedDriver().prepare(prepared);
+ try {
Review comment:
I assume we are capturing query prepare time for lens query to monitor its
performance. If that's the case its always better to emit metric that indicates
average prepare query time over last 5 mins, 60 min, etc.
PREPARED_QUERIES_COUNTER is different counter I am asking you to emit one for
prepare time with aggregation that can be used to raise an alert. To monitor
performance by looking into db is not good practice. It is being used mostly
for bookkeeping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276535)
Time Spent: 1h 20m (was: 1h 10m)
> Fixed a Bug and made changes for PreparedQuery
> ----------------------------------------------
>
> Key: LENS-1545
> URL: https://issues.apache.org/jira/browse/LENS-1545
> Project: Apache Lens
> Issue Type: Improvement
> Components: api, cube, server
> Reporter: Rajashekhar
> Assignee: Amareshwari Sriramadasu
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Fixed following Issues in Lens for Azure Migrations
> # Bug in Lens-Metastore for single fact granularity --
> https://issues.apache.org/jira/browse/LENS-1544. Explaination: This had a
> special case for handling facts with one-update-period and
> multiple-update-periods. The case which handled one-update-period had a bug
> while generating the name of the hive table whole format is
> update_period-fact_name, the update_period was coming as null.
> # JDBCDriver.java was invoking JDBC Driver while validating the prepared
> query, I don't need this functionality so blocking this via already existing
> config parameter JDBC_VALIDATE_THROUGH_PREPARE.
> 2a) Old Flow:
> {code}
> esitmate()
> --- | --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> ----------------|--> rewrite -- Rewritting take place
> {code}
> 2b) New Flow:
> {code}
> esitmate()
> ---| --> rewrite -- Rewritting take place
> ---| --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
