-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31669/#review74915
-----------------------------------------------------------
Ran examples and here are all the gauges for one of the query :
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-ALL_CUBE_REWRITES"
: {
"value" : 257
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-ALL_DRIVER_ESTIMATES"
: {
"value" : 274
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-DRIVER_SELECTION"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-driverEstimate"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.AggregateResolver-ITER-8"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.AliasReplacer-ITER-2"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.CandidateTableResolver-ITER-4"
: {
"value" : 2
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.CandidateTableResolver-ITER-7"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.ColumnResolver-ITER-1"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.DenormalizationResolver-ITER-14"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.DenormalizationResolver-ITER-3"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.ExpressionResolver-ITER-0"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.GroupbyResolver-ITER-9"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.JoinResolver-ITER-5"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.LeastPartitionResolver-ITER-15"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.LightestDimensionResolver-ITER-17"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.LightestFactResolver-ITER-12"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.LightestFactResolver-ITER-16"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-10"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-11"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-13"
: {
"value" : 51
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.cube.parse.TimerangeResolver-ITER-6"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.driver.cube.RewriteUtil-rewriteQuery"
: {
"value" : 112
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-HiveDriver-org.apache.lens.driver.cube.RewriteUtil-rewriteQuery-toHQL"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-columnar-sql-rewrite"
: {
"value" : 272
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-driverEstimate"
: {
"value" : 274
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-jdbc-prepare-statement"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.AggregateResolver-ITER-8"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.AliasReplacer-ITER-2"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.CandidateTableResolver-ITER-4"
: {
"value" : 2
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.CandidateTableResolver-ITER-7"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.ColumnResolver-ITER-1"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.DenormalizationResolver-ITER-14"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.DenormalizationResolver-ITER-3"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.ExpressionResolver-ITER-0"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.GroupbyResolver-ITER-9"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.JoinResolver-ITER-5"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.LeastPartitionResolver-ITER-15"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.LightestDimensionResolver-ITER-17"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.LightestFactResolver-ITER-12"
: {
"value" : 1
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.LightestFactResolver-ITER-16"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-10"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-11"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.StorageTableResolver-ITER-13"
: {
"value" : 16
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.cube.parse.TimerangeResolver-ITER-6"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.driver.cube.RewriteUtil-rewriteQuery"
: {
"value" : 71
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-org.apache.lens.driver.cube.RewriteUtil-rewriteQuery-toHQL"
: {
"value" : 0
},
"lens.MethodMetricGauge.46f0ab75-1586-41d8-a102-37c6cb1167c3-JDBCDriver-validate-thru-prepare"
: {
"value" : 273
},
- Amareshwari Sriramadasu
On March 3, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31669/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 7:11 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
>
>
> Bugs: LENS-283
> https://issues.apache.org/jira/browse/LENS-283
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Added query level configuration to instrument estimate flow
> - Methods instrumented to create gauges.
> - Moved metrics related common classes to lens-server-api sothat they can be
> used in other modules
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
> ba19125
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java
> 0e9ca25
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
> 1257092
> lens-server-api/pom.xml 8472840
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
> ca87fa3
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/LensMetricsRegistry.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricGauge.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
> f141428
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
> 1c04952
>
> lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
> PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java
> 6a60421
>
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java
> f035848
>
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
> 3f20bfd
>
> lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
> 307ae10
>
> lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
> a3dca46
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
> 15b9849
> lens-server/src/main/resources/lenssession-default.xml f145358
>
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java
> 9e1c23f
>
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
> a0abb0a
> src/site/apt/admin/config.apt 6445fe7
> src/site/apt/admin/session-config.apt d1c36bb
>
> Diff: https://reviews.apache.org/r/31669/diff/
>
>
> Testing
> -------
>
> Pending unit tests.
>
> Will update full test run once done.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
