-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31669/
-----------------------------------------------------------
(Updated March 6, 2015, 6:04 a.m.)
Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
Changes
-------
Added unit tests and incorporated review comments
Bugs: LENS-283
https://issues.apache.org/jira/browse/LENS-283
Repository: lens
Description
-------
Changes include :
- Added query level configuration to instrument estimate flow
- Methods instrumented to create gauges.
- Moved metrics related common classes to lens-server-api sothat they can be
used in other modules
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
ba19125
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 0e9ca25
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java
PRE-CREATION
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java
df81054
lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java
98aeb25
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
774f43f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
1257092
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
68bd19b
lens-server-api/pom.xml 8472840
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
ff25fa2
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/LensMetricsRegistry.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricGauge.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
f141428
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
1c04952
lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java
175eab3
lens-server-api/src/test/java/org/apache/lens/server/api/metrics/TestMethodMetricsFactory.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java
6a60421
lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java
f035848
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
3f20bfd
lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
307ae10
lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
a3dca46
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
2f44938
lens-server/src/main/resources/lenssession-default.xml f145358
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java
9e1c23f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
ea991b7
src/site/apt/admin/session-config.apt d1c36bb
Diff: https://reviews.apache.org/r/31669/diff/
Testing (updated)
-------
Unit tests added for all the new code introduced.
Will update full test run once done.
Thanks,
Amareshwari Sriramadasu
