----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31669/#review75153 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java <https://reviews.apache.org/r/31669/#comment122111> Why is this required? lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java <https://reviews.apache.org/r/31669/#comment122112> Which stack is this? lens-server-api/src/main/java/org/apache/lens/server/api/metrics/LensMetricsRegistry.java <https://reviews.apache.org/r/31669/#comment122117> I don't think we should start metrics registry in server-api. It should be done in metrics service only. Server-API should not force any instances on dependent modules. Same goes for the static factory instance. If not possible to move at all, make these lazy allocations. lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java <https://reviews.apache.org/r/31669/#comment122104> This and the above class have same Javadoc What is the difference? lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java <https://reviews.apache.org/r/31669/#comment122105> This and the above class have same Javadoc What is the difference? lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java <https://reviews.apache.org/r/31669/#comment122114> I wonder why we need more singletons. Do we really need more static variables? Is it not possible to contain them in some service? lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java <https://reviews.apache.org/r/31669/#comment122108> Null check repeated twice? lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java <https://reviews.apache.org/r/31669/#comment122109> Are we appending request values to the metric name? lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java <https://reviews.apache.org/r/31669/#comment122113> Can we use Query handle here instead of one more UUID? lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java <https://reviews.apache.org/r/31669/#comment122115> This comment is too abstract. I couldn't understand why this class is needed. Which server code is this useful for? What do you mean by model object? Is this model from the MVC pattern? lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java <https://reviews.apache.org/r/31669/#comment122116> Why IllegalArgumentException? Please include error message. Also, will this exception ovverride any HTTP errors? lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java <https://reviews.apache.org/r/31669/#comment122118> This fix has gone in already. Diff might need rebase. - Jaideep dhok On March 3, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31669/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 7:11 a.m.) > > > Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal. > > > Bugs: LENS-283 > https://issues.apache.org/jira/browse/LENS-283 > > > Repository: lens > > > Description > ------- > > Changes include : > > - Added query level configuration to instrument estimate flow > - Methods instrumented to create gauges. > - Moved metrics related common classes to lens-server-api sothat they can be > used in other modules > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > ba19125 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 0e9ca25 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 1257092 > lens-server-api/pom.xml 8472840 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > ca87fa3 > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/LensMetricsRegistry.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricGauge.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > f141428 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 1c04952 > > lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/model/LensResourceMethod.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java > 6a60421 > > lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java > f035848 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3f20bfd > > lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java > 307ae10 > > lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java > a3dca46 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 15b9849 > lens-server/src/main/resources/lenssession-default.xml f145358 > > lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java > 9e1c23f > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > a0abb0a > src/site/apt/admin/config.apt 6445fe7 > src/site/apt/admin/session-config.apt d1c36bb > > Diff: https://reviews.apache.org/r/31669/diff/ > > > Testing > ------- > > Pending unit tests. > > Will update full test run once done. > > > Thanks, > > Amareshwari Sriramadasu > >
