-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31669/#review75669
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 9, 2015, 6:20 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31669/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 6:20 a.m.)
> 
> 
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
> 
> 
> Bugs: LENS-283
>     https://issues.apache.org/jira/browse/LENS-283
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> 
> - Added query level configuration to instrument estimate flow
> - Methods instrumented to create gauges.
> - Moved metrics related common classes to lens-server-api sothat they can be 
> used in other modules
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> ba19125 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 
> 0e9ca25 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 
> df81054 
>   lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 
> 98aeb25 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  774f43f 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 1257092 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  68bd19b 
>   lens-server-api/pom.xml 8472840 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  ff25fa2 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/LensMetricsRegistry.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricGauge.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetrics.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsFactory.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  f141428 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
>  1c04952 
>   
> lens-server-api/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java
>  175eab3 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/metrics/TestMethodMetricsFactory.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java 
> 6a60421 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java
>  f035848 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3f20bfd 
>   
> lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java
>  307ae10 
>   
> lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java
>  a3dca46 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2f44938 
>   lens-server/src/main/resources/lenssession-default.xml f145358 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 
> a695b5d 
>   
> lens-server/src/test/java/org/apache/lens/server/api/metrics/LensMetricsUtil.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java
>  9e1c23f 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> ea991b7 
>   src/site/apt/admin/session-config.apt d1c36bb 
> 
> Diff: https://reviews.apache.org/r/31669/diff/
> 
> 
> Testing
> -------
> 
> Unit tests added for all the new code introduced.
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.188s]
> [INFO] Lens .............................................. SUCCESS [1.738s]
> [INFO] Lens API .......................................... SUCCESS [5.248s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.774s]
> [INFO] Lens Cube ......................................... SUCCESS [8:52.675s]
> [INFO] Lens DB storage ................................... SUCCESS [34.426s]
> [INFO] Lens Query Library ................................ SUCCESS [19.669s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:56.653s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [25.594s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.527s]
> [INFO] Lens client ....................................... SUCCESS [25.469s]
> [INFO] Lens CLI .......................................... SUCCESS [2:08.664s]
> [INFO] Lens Examples ..................................... SUCCESS [1.274s]
> [INFO] Lens Distribution ................................. SUCCESS [11.660s]
> [INFO] Lens ML Lib ....................................... SUCCESS [52.988s]
> [INFO] Lens Regression ................................... SUCCESS [0.486s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 22:37.988s
> [INFO] Finished at: Mon Mar 09 06:19:10 UTC 2015
> [INFO] Final Memory: 111M/1251M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to