-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86166
-----------------------------------------------------------


Changes look fine. Can you include unit tests?

- Amareshwari Sriramadasu


On June 1, 2015, 9:39 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-531
>     https://issues.apache.org/jira/browse/LENS-531
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> added command
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1e8d71d8ce430ad0404ec425e738d5de2529a03f 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
> d05d7a516d2c65b081464e84858a593ab8f0e1bf 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 
> 86099d3b65ef03be62825e1abcdf8ce88f2a1f60 
>   
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java 
> b599d6ed469354596e972ffafe75716eb5239378 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java 
> e5524bda29c55e7bb17ab081f8170716a297af18 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> cd8bf166e11786ae8ec26df8d03dd381ef62d787 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> a6651f6a8f896974498d3c29a88c1c1ad0b54b49 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  5a1f8f9e4920e76a7436183776b3785d05f7869d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
>  890da4cbd365a6b01381a110f9888a5491b49727 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  64f6cd4bddeadfccc8ab992fcdf16151a29d3c24 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  e746ebbe5035fcc43563a5509f1dbf67d51980db 
>   pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a 
> 
> Diff: https://reviews.apache.org/r/34885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to