> On June 3, 2015, 3:34 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 263 > > <https://reviews.apache.org/r/34885/diff/3/?file=977378#file977378line263> > > > > join_chains are not fields. We give flattenedColumns which returns > > fields from all chains along with direct fields. > > > > {cubename}/fields can return only direct fields.
if flattened is already there, I'm inclined towards reusing it. adding new rest end point for similar purpose doesn't make sense. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34885/#review86384 ----------------------------------------------------------- On June 3, 2015, 3:20 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34885/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 3:20 p.m.) > > > Review request for lens. > > > Bugs: LENS-531 > https://issues.apache.org/jira/browse/LENS-531 > > > Repository: lens > > > Description > ------- > > added command > > > Diffs > ----- > > lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2 > lens-api/src/main/resources/cube-0.1.xsd > 719d10d94f638718d25c0b91f00abea75414ddf5 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > d05d7a516d2c65b081464e84858a593ab8f0e1bf > lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java > 86099d3b65ef03be62825e1abcdf8ce88f2a1f60 > > lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java > b599d6ed469354596e972ffafe75716eb5239378 > lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java > e5524bda29c55e7bb17ab081f8170716a297af18 > lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java > PRE-CREATION > > lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java > PRE-CREATION > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > ae39a2abe01d175c927fa2dcb80836c628e5c3ab > lens-client/src/main/java/org/apache/lens/client/LensClient.java > cd8bf166e11786ae8ec26df8d03dd381ef62d787 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 44f4f1f49894f235568aabc3de128879a233b35c > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 890da4cbd365a6b01381a110f9888a5491b49727 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e746ebbe5035fcc43563a5509f1dbf67d51980db > pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a > > Diff: https://reviews.apache.org/r/34885/diff/ > > > Testing > ------- > > lens-shell>cube show fields sales > dim attributes > ======================= > Name Display String Description > -------------------- --------------- > -------------------------------------------- > delivery_city_name Delivery City City name to which the product was > delivered > production_city_name Production City City name in which the product was > produced > production_city_id > product_id > order_id > delivery_city_id > customer_city_name Customer City City name to which the customer > belongs > delivery_time > order_time > order_line_number > customer_city_id > promotion_id > customer_id > > measures > ======================= > Name Display String Description > ------------------------- -------------------------- ----------- > rating Rating > line_item_quantity Line item quantity > store_sales Store Sales > unit_sales Unit Sales > line_item_tax Line item tax > max_line_item_discount Maximum Line item discount > store_cost Store Cost > max_line_item_price Maximum Line item price > line_item_discount_amount Line item discount > line_item_product_price Line item product price > > expr columns > ======================= > Name Display String Description Expr Specs > --------------- --------------- ----------- > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > profit Profit always valid: store_sales - > store_cost > promotion_sales Promotion sales after > 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else > store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when > promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end) > > join chains > ======================= > Name Display String Description Destination Table Paths > ---------------- -------------- ----------- ----------------- > --------------------------------------------------------------------------------------- > customer_details customer > sales.customer_id=customer.id > customer_city city > sales.customer_city_id=city.id, > sales.customer_id=customer.id->customer.city_id=city.id > product_details product > sales.product_id=product.id > production_city city > sales.production_city_id=city.id > delivery_city city > sales.delivery_city_id=city.id > > > lens-shell> > > > Thanks, > > Rajat Khandelwal > >
