[
https://issues.apache.org/jira/browse/LENS-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630923#comment-14630923
]
Rajat Khandelwal commented on LENS-671:
---------------------------------------
After LENS-652, I believe user should be able to get the same partition xml and
make a PUT request with the same xml. I'd almost made the changes for removing
full_partition_spec in that. The only thing that caused me to revert those was
because when a time partition value is 'latest', it can not be split into time
spec and non time spec. So I can safely say the only reason we are returning
full_spec in a read request is to support the case of partitions where a time
part has value 'latest'.
When you think about it, for the uninitiated, it's confusing that when he adds
one partition, and asks for list of all partitions, he gets two. Frankly, the
existence of 'latest' partitions is an implementation detail in lens and the
user of lens should not be concerned about that. It's one implementation detail
chosen out of many and is subject to change in further iterations. Considering
Information Hiding, this should not be exposed to the user. Once we hide that
information, it'll ease the way for this issue.
Essentially we've chosen to expose implementation details in favor of easy
debuggability. Which is fine for an evolving project, but as it grows it might
start causing problems in other areas. Such as this. As this issue is merged
and user base grows, the partition api will seem inconsistent and confusing to
the users. When you do a POST or PUT, you provide time part spec and non time
part spec. When you get, you don't get what you had POSTed or PUT. You get
something similar, but *different*.
> Remove full_partition_spec from partition definition in cube xsd
> ----------------------------------------------------------------
>
> Key: LENS-671
> URL: https://issues.apache.org/jira/browse/LENS-671
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Rajat Khandelwal
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
