> On Aug. 5, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote: > > Changes look good. Can you include a test case?
Do you have any suggestion on what new testcase to add? this code is in path for all the existing lensclient requests. I can probably add a test on adding an implementation for RequestFilter, but I don't know if there already exists a framework that I can reuse where the external jar is created and then tested. Can you point me to such a test.. - Pranav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37117/#review94194 ----------------------------------------------------------- On Aug. 5, 2015, 5:42 a.m., Pranav Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37117/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 5:42 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens-702 Ability to inspect GET and POST request that are to be submitted to > Lens Server > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > edb56ac9f008963e89cf57d664916a6732a2ff42 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 61e16f7ec5fc06f060f4939587576f4118fce612 > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java > 6b5b45cfc2f2dcfe5b1edddef56b39088b3d47d0 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > b4e05524debaa747674014607a6047b9c3b3b63b > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > f7305fb288167cda088e263a62c77f264d779127 > lens-client/src/main/java/org/apache/lens/client/RequestFilter.java > PRE-CREATION > lens-client/src/main/resources/lens-client-default.xml > 5a8b019f3f11cc2d65bc0899f9132572cf52e50b > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java > c68dd12e964a4bcf5c7ffcbd1f39da938620bd2e > > Diff: https://reviews.apache.org/r/37117/diff/ > > > Testing > ------- > > mvn clean install was good > > > Thanks, > > Pranav Agarwal > >
