----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37117/#review94343 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 124) <https://reviews.apache.org/r/37117/#comment148915> required blank line? lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java (line 29) <https://reviews.apache.org/r/37117/#comment148912> Can we use slf4j logging instead of commons logging? Removed commons logging dependency as part of [LENS-680](https://issues.apache.org/jira/browse/LENS-680). lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java (line 52) <https://reviews.apache.org/r/37117/#comment148913> Seems this is not required if we use @slf4j lombok. lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java (line 62) <https://reviews.apache.org/r/37117/#comment148914> Adding **null** to filter list? lens-client/src/main/resources/lens-client-default.xml (line 44) <https://reviews.apache.org/r/37117/#comment148916> indentation? - Raju Bairishetti On Aug. 5, 2015, 5:42 a.m., Pranav Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37117/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 5:42 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens-702 Ability to inspect GET and POST request that are to be submitted to > Lens Server > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > edb56ac9f008963e89cf57d664916a6732a2ff42 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 61e16f7ec5fc06f060f4939587576f4118fce612 > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java > 6b5b45cfc2f2dcfe5b1edddef56b39088b3d47d0 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > b4e05524debaa747674014607a6047b9c3b3b63b > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > f7305fb288167cda088e263a62c77f264d779127 > lens-client/src/main/java/org/apache/lens/client/RequestFilter.java > PRE-CREATION > lens-client/src/main/resources/lens-client-default.xml > 5a8b019f3f11cc2d65bc0899f9132572cf52e50b > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java > c68dd12e964a4bcf5c7ffcbd1f39da938620bd2e > > Diff: https://reviews.apache.org/r/37117/diff/ > > > Testing > ------- > > mvn clean install was good > > > Thanks, > > Pranav Agarwal > >
