----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37117/#review94751 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java (line 55) <https://reviews.apache.org/r/37117/#comment149352> well, tomorrow there can be other filters that need not necessarily extend ClientRequestFilter lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java (line 62) <https://reviews.apache.org/r/37117/#comment149353> Thanks for catching it.. fixed.. lens-client/src/main/resources/lens-client-default.xml (line 44) <https://reviews.apache.org/r/37117/#comment149354> Thanks, fixed it.. - Pranav Agarwal On Aug. 10, 2015, 4:44 p.m., Pranav Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37117/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 4:44 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > review comments > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > f71c58f4734282d08de2b2c633a3ba9bd5bf077a > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 5de8c089c572d7d0faa0880f99e8c8d4f6392f64 > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java > ccd4a9877cd4adc8765b99d687c2155b71ad25dc > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 3637ab8f6b6d8b42f3b577986fc91ded3c556628 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > 4612f6a5e1a13e4000ac0ef9e6f9db48b8c15881 > lens-client/src/main/java/org/apache/lens/client/RequestFilter.java > PRE-CREATION > lens-client/src/main/resources/lens-client-default.xml > 5a8b019f3f11cc2d65bc0899f9132572cf52e50b > lens-client/src/test/java/org/apache/lens/client/RequestTestFilter.java > PRE-CREATION > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 35d52dbf0ff38a81bb9b3b6bdbd038a950edb76c > lens-client/src/test/resources/lens-client-site.xml PRE-CREATION > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java > 875e69207e6f18ff1e7d68dc18661229b755fe03 > > Diff: https://reviews.apache.org/r/37117/diff/ > > > Testing > ------- > > mvn clean install was good > > > Thanks, > > Pranav Agarwal > >
