I am still reviewing it. As Matt noted, you can merge it. This said, I'd appreciate an extra week. It is easier to discuss changes over GitHub PR. Once committed, PR will disappear.
On Thu, Apr 1, 2021 at 5:58 AM Ralph Goers <ralph.go...@dslextreme.com> wrote: > FYI - I plan on merging this code Friday morning MST unless my schedule > changes between now and then. > > Ralph > > > On Mar 29, 2021, at 3:58 PM, Ralph Goers <ralph.go...@dslextreme.com> > wrote: > > > > I should have added that you may need a recent version of the JDK. I > forget what error I was encountering but upgrading the JDK to a later > version fixed it. But then I noticed that the Google java allocation > instrumenter wasn’t working and it had to be upgraded too. > > > > Ralph > > > >> On Mar 29, 2021, at 3:51 PM, Matt Sicker <boa...@gmail.com> wrote: > >> > >> I’ll make sure to look more closely at it this week. Nice work on > >> simplifying the modules a bit! > >> > >> On Sun, Mar 28, 2021 at 18:24 Ralph Goers <ralph.go...@dslextreme.com> > >> wrote: > >> > >>> I have created https://github.com/apache/logging-log4j2/pull/480 for > you > >>> to review. It has many changes and merge conflicts will be painful to > fix > >>> so please do not commit to master until this PR is merged. > >>> > >>> Although I could merge this now I would prefer if you could checkout > the > >>> branch on your local machines, build, and test it. I haven’t tested it > with > >>> anything real yet but all the unit tests - except for the osgi module - > >>> pass. > >>> > >>> If you open this in your IDE you might have some issues with some test > >>> classes being flagged as having compile issues. This is because of the > >>> weird extra directory I had to include in log4j-api and log4j-plugins > to > >>> create test jars. > >>> > >>> Please provide feedback so I can make any changes and get this merged. > >>> > >>> Ralph > >>> > > > > > > > > >
