Great work Ralph! Your change set marks an important milestone in Log4j development. Thanks so much!
`./mvnw verify` fails for me while compiling the 2nd module, log4j-api: `error: module not found: org.osgi.core`. Any ideas? This said `./mvnw package` succeeds for me, hence all(?) tests pass. $ java -version openjdk version "11.0.10" 2021-01-19 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.10+9) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode) $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.10 Release: 20.10 Codename: groovy I have a remark/question regarding removed test-jars. If I am not mistaken test-jars were only used for testing purposes, so these *-test modules you have introduced. For one, I am happy to see that test-jars were replaced with normal module artifacts, at least just for these. Test-jars were difficult to get right, producing cryptic dependency failures, and not an often-practiced part of the Maven rituals. This said, shall we prevent them from getting published? That is, do we need to publish them to the Maven Central, given they are only needed for internal testing? On Mon, Mar 29, 2021 at 1:24 AM Ralph Goers <ralph.go...@dslextreme.com> wrote: > I have created https://github.com/apache/logging-log4j2/pull/480 for you > to review. It has many changes and merge conflicts will be painful to fix > so please do not commit to master until this PR is merged. > > Although I could merge this now I would prefer if you could checkout the > branch on your local machines, build, and test it. I haven’t tested it with > anything real yet but all the unit tests - except for the osgi module - > pass. > > If you open this in your IDE you might have some issues with some test > classes being flagged as having compile issues. This is because of the > weird extra directory I had to include in log4j-api and log4j-plugins to > create test jars. > > Please provide feedback so I can make any changes and get this merged. > > Ralph >
