The main benefit of that IMO is only if you wait for all GitHub builds to
succeed; I imagine we'd want Windows, macOS, and Linux.
Gary
On Fri, Apr 15, 2022, 09:37 Ralph Goers <ralph.go...@dslextreme.com> wrote:
> I was OK with requiring PRs that I could self approve.
>
> Ralph
>
> > On Apr 15, 2022, at 3:28 PM, Volkan Yazıcı <vol...@yazi.ci> wrote:
> >
> > I don't think so. `PluginManager` accesses
> `PluginRegistry.getInstance()`,
> > where the plugins are already cached. `PluginManager#collectPlugins()`
> > simply filters them using the given category key.
> >
> > On Fri, Apr 15, 2022 at 1:51 PM Remko Popma <remko.po...@gmail.com>
> wrote:
> >
> >> Maybe the complaints about startup time have to do with this:
> >>
> >> note that every time a PatternParser is instantiated, we load all
> plugins
> >> again...
> >>
> >> public PatternParser(final Configuration config, final String
> >> converterKey, final Class<?> expectedClass,
> >> final Class<?> filterClass) {
> >> this.config = config;
> >> final PluginManager manager = new PluginManager(converterKey);
> >> manager.collectPlugins(config == null ? null :
> >> config.getPluginPackages());
> >>
>
>
