Thanks for the responses. It just struck me as I was debugging something, but I did not actually measure whether this is a real bottleneck. What Volkan and Matt are saying makes sense, that it is unlikely that this is actually a bottleneck.
On Sat, Apr 16, 2022 at 3:33 AM Matt Sicker <[email protected]> wrote: > I updated how that works in master to reuse the PluginManager that has > already called collectPlugins() once (so it even avoids redundant > re-scans of the in-memory maps), but that doesn't seem to be much of > an issue anymore (especially now that all the StrLookup plugins are > themselves instantiated only on first use). > > On Fri, Apr 15, 2022 at 6:51 AM Remko Popma <[email protected]> wrote: > > > > Maybe the complaints about startup time have to do with this: > > > > note that every time a PatternParser is instantiated, we load all plugins > > again... > > > > public PatternParser(final Configuration config, final String > > converterKey, final Class<?> expectedClass, > > final Class<?> filterClass) { > > this.config = config; > > final PluginManager manager = new PluginManager(converterKey); > > manager.collectPlugins(config == null ? null : > config.getPluginPackages()); >
