On Wed, Nov 8, 2023, at 09:04, Volkan Yazıcı wrote:
> I completely agree with Matt. With or without IDE plugins, we run `./mvnw
> spotless:apply` anyway. Hence, lack of Eclipse support is not a blocker,
> IMO. Gary is covered.
>
> +1 deterministic formatter (don't have an opinion on Palantir-vs-Google)
>
> Piotr, it has been two months or so since we are discussing this. No
> objections so far. Please go ahead and implement this. It will help a lot
> for sync'ing `2.x` and `3.x`.
>
+1,
I like the palantir formatter the most for the same reasons Matt mentioned.
Since it can be done using Maven, I don't know why an IDE should block it.
Christian
> On Tue, Nov 7, 2023 at 7:10 PM Matt Sicker <m...@musigma.org> wrote:
>
>> In the worst case scenario, we can still format from maven before
>> committing (which is what I used to do before finding that there were
>> IntelliJ plugins for this). In fact, I have to do that all the time lately
>> anyways by running `mvn spotless:apply`.
>>
>> > On Nov 6, 2023, at 9:00 AM, Carter Kozak <cko...@ckozak.net.INVALID>
>> wrote:
>> >
>> > I'd be happy to review+release changes to get the eclipse plugin in that
>> repo into a good place as long as it doesn't make the build process a great
>> deal more complicated. We don't have many folks internally using eclipse so
>> support hasn't been a priority, but the easier it is to use across common
>> toolchains, the better!
>> >
>> > -ck
>> >
>> > On Mon, Nov 6, 2023, at 06:55, Piotr P. Karwasz wrote:
>> >> Hi Gary,
>> >>
>> >> On Mon, 6 Nov 2023 at 11:45, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>> >>>
>> >>> Well, I use Eclipse, so... I won't be using whatever this does or when
>> it
>> >>> does it.
>> >>
>> >> What version of Eclipse do you use? The Eclipse plugin is one class, I
>> >> can probably fix it, compile it and release it.
>> >>
>> >> Piotr
>> >>
>>
>>
