[ https://issues.apache.org/jira/browse/LUCENE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868660#action_12868660 ]
Michael McCandless commented on LUCENE-2468: -------------------------------------------- Renaming to cacheKey makes me a bit nervous.... since... this key is the same even when deletions change. How about coreCacheKey? The javadocs should make it clear that new deletions can show up yet have the identical (==) coreCacheKey. OK I'll take this approach. > reopen on NRT reader should share readers w/ unchanged segments > --------------------------------------------------------------- > > Key: LUCENE-2468 > URL: https://issues.apache.org/jira/browse/LUCENE-2468 > Project: Lucene - Java > Issue Type: Bug > Reporter: Yonik Seeley > Assignee: Michael McCandless > Attachments: CacheTest.java, LUCENE-2468.patch > > > A repoen on an NRT reader doesn't seem to share readers for those segments > that are unchanged. > http://search.lucidimagination.com/search/document/9f0335d480d2e637/nrt_and_caching_based_on_indexreader -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org