[
https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887506#comment-13887506
]
Lei Wang commented on LUCENE-5425:
----------------------------------
agree it can be a done in a separate issue. didn't know a wrapper will affect
performance that much. it's just an additional method call to me. the default
OpenBitSetIterator impl is different with nextSetBit, maybe that's the reason?
anyway, start with this change won't hurt anything. and caching of the bitset
should be able to get 20% down on the overhead of new a bitset each time (the
other 80% is from the memset). After getting this in, i can do a separate test
on the DocIdSet. See if we can get an acceptable performance for the default
behavior without reusing the memory.
> Make creation of FixedBitSet in FacetsCollector overridable
> -----------------------------------------------------------
>
> Key: LUCENE-5425
> URL: https://issues.apache.org/jira/browse/LUCENE-5425
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 4.6
> Reporter: John Wang
> Attachments: facetscollector.patch
>
>
> In FacetsCollector, creation of bits in MatchingDocs are allocated per query.
> For large indexes where maxDocs are large creating a bitset of maxDoc bits
> will be expensive and would great a lot of garbage.
> Attached patch is to allow for this allocation customizable while maintaining
> current behavior.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]