[
https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888452#comment-13888452
]
Shai Erera commented on LUCENE-5425:
------------------------------------
Just to make sure I don't come across wrong - when Mike and I started the
facets package overhauling a year ago, the package was full of general and
abstract APIs. Really, you could do both what this issue wants to achieve and
even LUCENE-5428 (IIRC). After Mike wrote a completely bypassing code-path for
faceted search and noted some 250% improvements, we decided to eliminate *all*
abstractions from the API, and re-introduce them gradually. Eventually we
settled on x4 speedups.
So I just want to make sure (both here and on LUCENE-5428) that the
abstractions that we add don't impact faceted search badly, and if they do and
we still want to introduce them, at least show that there's some code path
where you actually improve things.
So please don't take my comments as objections, but just being cautious and
this time prefer that whatever abstraction that we add, is measured from all
sides.
> Make creation of FixedBitSet in FacetsCollector overridable
> -----------------------------------------------------------
>
> Key: LUCENE-5425
> URL: https://issues.apache.org/jira/browse/LUCENE-5425
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 4.6
> Reporter: John Wang
> Attachments: facetscollector.patch, facetscollector.patch
>
>
> In FacetsCollector, creation of bits in MatchingDocs are allocated per query.
> For large indexes where maxDocs are large creating a bitset of maxDoc bits
> will be expensive and would great a lot of garbage.
> Attached patch is to allow for this allocation customizable while maintaining
> current behavior.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
