[
https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887548#comment-13887548
]
Shai Erera commented on LUCENE-5425:
------------------------------------
bq. didn't know a wrapper will affect performance that much.
Me neither! We were very surprised to see some of the performance implications
of saving a method call or changing the order we iterate on results + facet
requests. But it's hard to argue w/ consistent numbers, and IIRC they weren't
in the 3-5% range, but 10+%. Could be though that we measured several changes
at once .. so I think it's worthwhile to benchmark the move to DocIdSet.
And yes, it could be OpenBitSetIterator, I don't rule it out.
+1 to allow caching in this issue, we can investigate generalizing the APIs in
a separate issue.
> Make creation of FixedBitSet in FacetsCollector overridable
> -----------------------------------------------------------
>
> Key: LUCENE-5425
> URL: https://issues.apache.org/jira/browse/LUCENE-5425
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 4.6
> Reporter: John Wang
> Attachments: facetscollector.patch
>
>
> In FacetsCollector, creation of bits in MatchingDocs are allocated per query.
> For large indexes where maxDocs are large creating a bitset of maxDoc bits
> will be expensive and would great a lot of garbage.
> Attached patch is to allow for this allocation customizable while maintaining
> current behavior.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
