[
https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895885#comment-13895885
]
Michael McCandless commented on LUCENE-5440:
--------------------------------------------
+1, it's nice to see how many OBS's you were able to cut over.
I especially loved seeing this pre-existing comment (again):
{noformat}
super(in, false); // <-- not passing false here wasted about 3 hours of
my time!!!!!!!!!!!!!
{noformat}
Maybe if we added a FixedBitSet.ensureCapacity then we could use FBS
in Numeric/BinaryDocValuesWriter? Seems like we should decouple elasticity
and long vs int index?
I find it crazy that SloppyPhraseScorer seems to allocate a new bitset
for every .advance call?
Maybe we should rename FBS -> IntFBS?
> Add LongFixedBitSet and replace usage of OpenBitSet
> ---------------------------------------------------
>
> Key: LUCENE-5440
> URL: https://issues.apache.org/jira/browse/LUCENE-5440
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5440.patch
>
>
> Spinoff from here: http://lucene.markmail.org/thread/35gw3amo53dsqsqj. I
> wrote a LongFixedBitSet which behaves like FixedBitSet, only allows managing
> more than 2.1B bits. It overcome some issues I've encountered with
> OpenBitSet, such as the use of set/fastSet as well the implementation of
> DocIdSet. I'll post a patch shortly and describe it in more detail.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]